Data: Registry - check for window #9261
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The registry code is blindly deferencing window, which will fail if ever run in node for test or server-side rendering. This adds a simple check to ensure window exists before dereferencing.
ockham
reviewed
Aug 23, 2018
packages/data/src/registry.js
Outdated
| @@ -140,7 +140,7 @@ export function createRegistry( storeConfigs = {} ) { | |||
| */ | |||
| function registerReducer( reducerKey, reducer ) { | |||
| const enhancers = []; | |||
| if ( window.__REDUX_DEVTOOLS_EXTENSION__ ) { | |||
| if ( window && window.__REDUX_DEVTOOLS_EXTENSION__ ) { | |||
There was a problem hiding this comment.
I think this check should be typeof window !== 'undefined' && -- otherwise, Automattic/wp-calypso#26838 won't even start for me but fail with a ReferenceError: window is not defined.
There was a problem hiding this comment.
Thanks, will update.
gziolo
added
the
Mobile App - i.e. Android or iOS
gziolo
approved these changes
Aug 25, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The current registry code is blindly deferencing window, which will fail if ever
run in node for test or server-side rendering. This adds a simple check
to ensure window exists before dereferencing.
How has this been tested?
There's not much to test for this line, as it only affects redux dev tools when there is no global window instance, which should never happen.
Types of changes
Sort of a bug fix maybe? As this code is causing a CI test to fail for Calypso: Automattic/wp-calypso#26838
This change should not break a thing, as it's just doing an additional check.
Checklist: